[PATCH] D65042: [Concept] Placeholder constraints and abbreviated templates

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 22 02:26:28 PDT 2019


martong added a comment.

`ASTImporter.cpp` and `ASTStructuralEquivalence.cpp` looks good to me!



================
Comment at: lib/AST/ASTImporter.cpp:1286
 
-  return Importer.getToContext().getAutoType(*ToDeducedTypeOrErr,
-                                             T->getKeyword(),
-                                             /*IsDependent*/false);
+  ExpectedDecl ToTypeConstraintConcept = import(T->getTypeConstraintConcept());
+  if (!ToTypeConstraintConcept)
----------------
LGTM!


================
Comment at: lib/AST/ASTStructuralEquivalence.cpp:732
 
-  case Type::Auto:
-    if (!IsStructurallyEquivalent(Context, cast<AutoType>(T1)->getDeducedType(),
-                                  cast<AutoType>(T2)->getDeducedType()))
+  case Type::Auto: {
+    auto *Auto1 = cast<AutoType>(T1);
----------------
This looks good to me!


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65042/new/

https://reviews.llvm.org/D65042





More information about the cfe-commits mailing list