[PATCH] D64592: [OpenMP] Fix declare target link implementation

Gheorghe-Teodor Bercea via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 19 09:22:04 PDT 2019


gtbercea marked an inline comment as done.
gtbercea added inline comments.


================
Comment at: test/OpenMP/declare_target_link_codegen.cpp:22-23
+// HOST-DAG: @c_decl_tgt_ref_ptr = weak global i32* @c
+// HOST-DAG: @_{{.*}}d = internal global i32 2
+// HOST-DAG: @_{{.*}}d_{{.*}}_decl_tgt_ref_ptr = weak global i32* @_{{.*}}d
 // DEVICE-NOT: @c =
----------------
ABataev wrote:
> Better to define the variable with the name of the original `d` variable for better and stable check
Can you rephrase your comment please? I don't understand what you'd like me to do here.

Do you want me to use  [[...]] to define the variable? 


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64592/new/

https://reviews.llvm.org/D64592





More information about the cfe-commits mailing list