[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 19 05:00:59 PDT 2019

kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

Thanks, LGTM from my side. Do you have any concerns @sammccall ?

Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:427
            R"cpp(void f(int a) {
                     auto dummy = 1; label: [ [gsl::suppress("type")] ] for (;;) a = dummy;
kadircet wrote:
> I think `auto dummy = 1;` should be within the label. otherwise we might break codes like(which is basically anything with labels):
> ```
> void foo() {
> goto label;
> label:
>  a = 1;
> }
> ```
> I don't think it is that important though, and have no idea about the effort necessary feel free to just add a FIXME if it turns out hard.
could you keep the previous test case within a `checkNotAvailable` block ?

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list