[PATCH] D64970: Handle windows line endings in QueryDriver

liu hui via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 18 22:21:25 PDT 2019

lh123 created this revision.
lh123 added reviewers: sammccall, kadircet.
lh123 added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, arphaman, jkorous, ilya-biryukov.
Herald added a project: clang.

The previous patch did not fix the end mark. D64789 <https://reviews.llvm.org/D64789>
fixes second case of https://github.com/clangd/clangd/issues/93

  rCTE Clang Tools Extra



Index: clang-tools-extra/clangd/QueryDriverDatabase.cpp
--- clang-tools-extra/clangd/QueryDriverDatabase.cpp
+++ clang-tools-extra/clangd/QueryDriverDatabase.cpp
@@ -59,7 +59,7 @@
 std::vector<std::string> parseDriverOutput(llvm::StringRef Output) {
   std::vector<std::string> SystemIncludes;
   const char SIS[] = "#include <...> search starts here:";
-  constexpr char const *SIE = "End of search list.";
+  const char SIE[] = "End of search list.";
   llvm::SmallVector<llvm::StringRef, 8> Lines;
   Output.split(Lines, '\n', /*MaxSplit=*/-1, /*KeepEmpty=*/false);
@@ -70,7 +70,9 @@
     return {};
-  const auto EndIt = std::find(StartIt, Lines.end(), SIE);
+  const auto EndIt =
+      llvm::find_if(llvm::make_range(StartIt, Lines.end()),
+                    [SIE](llvm::StringRef Line) { return Line.trim() == SIE; });
   if (EndIt == Lines.end()) {
     elog("System include extraction: end marker missing: {0}", Output);
     return {};

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64970.210734.patch
Type: text/x-patch
Size: 1037 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190719/651fa643/attachment.bin>

More information about the cfe-commits mailing list