[PATCH] D64958: [clang-doc] Fix link generation

[Diego Astiazarán via Phabricator via cfe-commits]

DiegoAstiazaran created this revision.
DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri.
DiegoAstiazaran added a project: clang-tools-extra.

Before making a link to a reference it is required to check that the reference has a path (eg. primitives won't have paths).
This was done by checking if the path was empty; that worked because when generating paths the outdirectory was included, so if a path was assigned it had that outdirectory at least.
The path generation was changed, it's now only the namespaces without the outdirectory. So if the info is in the global namespace the path would be empty and the old check wouldn't work as expected.
A new attribute has been added to the Reference struct that indicates if the object has a valid path, this is false by default and changed to true if a path is assigned to it.


https://reviews.llvm.org/D64958

Files:
  clang-tools-extra/clang-doc/BitcodeReader.cpp
  clang-tools-extra/clang-doc/BitcodeWriter.cpp
  clang-tools-extra/clang-doc/BitcodeWriter.h
  clang-tools-extra/clang-doc/HTMLGenerator.cpp
  clang-tools-extra/clang-doc/Representation.h
  clang-tools-extra/clang-doc/YAMLGenerator.cpp
  clang-tools-extra/unittests/clang-doc/YAMLGeneratorTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64958.210698.patch
Type: text/x-patch
Size: 5839 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190718/d11153aa/attachment-0001.bin>