[PATCH] D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 18 13:28:02 PDT 2019

rnk added a comment.

In D64799#1591732 <https://reviews.llvm.org/D64799#1591732>, @ilya-biryukov wrote:

> @rsmith, I'll look into emitting the typos when we pop expression evaluation context, but do we expect this to cover **all** cases where `TypoExpr`s are produced?
>  (conservatively assuming that the answer is "no") should we land this patch and also emit at the end of TU in addition to expression evaluation context?

I was going to pose the question this way: suppose clang already diagnosed typos when leaving an expr evaluation context, when appropriate. Would it still make sense to relax this assertion to diagnose any remaining ones at end of TU? Are we confident that we can catch all the typos, always? I'm not confident that everything will be handled, so I think we should take this change as is.

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list