[PATCH] D41412: [libcxx] implement <experimental/simd> concat() and split()

Tobias Grosser via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 18 09:55:57 PDT 2019

grosser added a comment.

It seems this patch went through at least one review and the only open comment is the discussion if __builtin_shuffle should be placed in the configuration. From my perspective, both solutions are technically feasible. While it seems unlikely that gcc will gain this specific builtin, I can see @mclow.lists  preferring to be consistent in keeping compiler-specific stuff in one file rather than having to evaluate for each extension the likeliness of this extension being adopted over time.

If you don't feel strongly about this change, I guess moving it to _config would address this last point and would require then only an ok, but no further discussions.

If you cannot reach @mclow.lists I am happy to either reach out or check for other reviewers.  Eric Fiselier seems very active at the moment.



More information about the cfe-commits mailing list