[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclarationsOnePerLine
Manikishan Ghantasala via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 18 09:20:25 PDT 2019
Manikishan marked an inline comment as done.
Manikishan added inline comments.
Comment at: lib/Format/FormatToken.h:524
+ T = T->getPreviousNonComment();
+ return (T->Tok.is(tok::comma) && Tok.is(tok::identifier) &&
> do you think you might need
> (T && T->Tok.is(tok::comma)......
I have found a method `FieldDecl::isBitField() ` which check whether a current field is a BitField, But `FieldDecl` is not used anywhere in `lib/Format/` . I think it may not be related to Formatting and so I have to modify my declaration of `isBitield()` in `FormatToken.h`.
Can I get suggestions whether my understanding is correct?
CHANGES SINCE LAST ACTION
More information about the cfe-commits