[PATCH] D64592: [OpenMP] Fix unified memory implementation for multiple compilation units
Gheorghe-Teodor Bercea via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 18 09:09:12 PDT 2019
gtbercea marked an inline comment as done.
gtbercea added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2610
+ auto *GV = cast<llvm::GlobalVariable>(Ptr);
> ABataev wrote:
> > Better to fix the link clause processing in a different patch, it has nothing to do with the unified memory.
> Sure I can split this patch.
It turns out that the patch cannot be split. Splitting the patch would lead to an intermediate state which produced incorrect results for certain corner cases.
CHANGES SINCE LAST ACTION
More information about the cfe-commits