[PATCH] D64712: [clangd] Refactor background-index shard loading

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 18 07:42:52 PDT 2019


sammccall added inline comments.


================
Comment at: clang-tools-extra/clangd/index/BackgroundIndexLoader.cpp:47
+    // Stores the absolute paths for the direct dependencies of this file.
+    std::vector<Path> Edges;
+  };
----------------
I think we only need to traverse this when *missing* the cache, so it can be a return value of loadShard rather than stored in CachedShard (so CachedShard becomes just LoadedShard)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64712/new/

https://reviews.llvm.org/D64712





More information about the cfe-commits mailing list