[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files
Xiao Shi via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 18 06:11:25 PDT 2019
shixiao marked an inline comment as done.
shixiao added inline comments.
Comment at: clang-tools-extra/test/clang-tidy/modernize-concat-nested-namespaces.h:1
> alexfh wrote:
> > Please put the header under Inputs/<check-name>/ directory to keep the tests directory a bit tidier. The header can then be renamed to something shorter, btw.
> Is it important to use `#pragma once` in this file? Can we use regular include guards instead?
It's not--I added it out of habit. Any particular reason to use regular include guards vs. `#pragma once`?
re: mv headers--sure, will do.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits