[PATCH] D64912: [Clangd] Changed ExtractVariable to only work on non empty selections
Shaurya Gupta via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 18 05:49:24 PDT 2019
SureYeaah marked an inline comment as done.
SureYeaah added inline comments.
Comment at: clang-tools-extra/clangd/refactor/Tweak.h:51
+ /// The Length of the selection
+ unsigned SelectionLength;
/// The AST nodes that were selected.
> maybe expose a `SourceLocation SelectionEnd` ?
Should I also have a SelectionStart? Or just use Cursor?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits