[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.
Haojian Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 18 04:42:55 PDT 2019
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Thanks! Looks good from my side.
@ilya-biryukov will be nice if you could take a second look on the patch. We plan to land it before the release cut today.
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1115
+ std::lock_guard<std::mutex> Lock(HighlightingsMutex);
+ Old = FileToHighlightings[File];
use std::move() to save a copy here. we'd drop the old highlighting anyway (replace it with new highlightings).
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits