[PATCH] D64867: [OpenCL] Update comments/diagnostics to refer to C++ for OpenCL mode
Anastasia Stulova via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 18 02:24:20 PDT 2019
Anastasia marked 2 inline comments as done.
Anastasia added inline comments.
Comment at: lib/Frontend/InitPreprocessor.cpp:414
- llvm_unreachable("Unsupported OpenCL C++ version");
+ llvm_unreachable("Unsupported C++ version for OpenCL");
> Shouldn't this be C++ for OpenCL version as in other places you use it as a noun
I think it refers to C++ version... but can probably be both.
Comment at: lib/Parse/ParseDecl.cpp:3562
- // OpenCL C++ v1.0 s2.9: the virtual function qualifier is not supported.
+ // C++ for OpenCL does not allow virtual function qualifier to avoid
+ // function pointers restricted in OpenCL v2.0 s6.9.a.
> need a comma between qualifier and to to remove ambiguity
Thanks! I will change in the final commit.
CHANGES SINCE LAST ACTION
More information about the cfe-commits