[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

Kristóf Umann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 18 02:00:00 PDT 2019

Szelethus added inline comments.

Comment at: lib/StaticAnalyzer/Checkers/Yaml.h:48
+  return Config;
Szelethus wrote:
> ```lang=c++
> } // end of namespace clang
> } // end of namespace ento
> ```
I mean, the other way around >.<

Comment at: test/Analysis/taint-generic.c:24
+// CHECK-INVALID-FILE-SAME:        'alpha.security.taint.TaintPropagation:Config',
+// CHECK-INVALID-FILE-SAME:        that expects a valid filename
NoQ wrote:
> Szelethus wrote:
> > Could you please add the rest of the error message?
> I'd rather remove the rest of the error message. There's no need to duplicate something that the user has already written on the command line.
> Or do we think like \escapes?
I'm not sure what \escapes mean -- however, if we emit the filename in the error message, we should test it. Also, how many filenames has the user written in the comand line? Include paths for this and that, output file, inputfile, files to link against... I would very much prefer preserving the current error message.



More information about the cfe-commits mailing list