[PATCH] D64741: [clangd] Added highlighting for tokens that are macro arguments.
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jul 17 01:31:59 PDT 2019
ilya-biryukov added a comment.
> I had completely missed that there could be conflicting tokens when only highlighting macro arguments as well. Added code to just remove conflicting tokens.
Picking one of the highlightings looks fine, but we probably want to make sure it's deterministic. Given that we use `sort` now, I bet it won't be. Maybe include kinds into comparison as well? That's not a perfect solution, but would at least make sure the user-visible behavior is not random.
Could you add tests for that case too?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits