[PATCH] D64712: [clangd][NFC] Refactor background-index shard loading
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jul 16 03:38:49 PDT 2019
sammccall added a comment.
So I've stared at this refactoring for a while, and I still don't totally get it.
It seems like a class that really wants to be a function. It's a complicated function though - maybe a separate cpp file does make sense.
We discussed moving ShardVersions and Writes into the loader, splitting ShardVersions from IndexSymbols seems pretty odd though.
What's the advantage of making this stateful?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits