[PATCH] D64554: [CrossTU] Add a function to retrieve original source location.
Gabor Marton via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jul 16 02:51:20 PDT 2019
martong added inline comments.
Comment at: include/clang/AST/ASTImporter.h:234
+ /// The ASTUnit that this importer belongs to, if any.
+ ASTUnit *Unit;
`Unit->getASTContext` must be equal to `FromContext`, right?
Then `FromUnit` would be a better naming.
The importer does handle two ASTContexts, so it would be great to know which ASTUnit's ASTContext is which. Or vica-versa, we must know precisely to which context does this unit belong. Also a comment would be useful that we must store the unit because there is no way to get that from the context.
CHANGES SINCE LAST ACTION
More information about the cfe-commits