[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 16 02:49:31 PDT 2019

Anastasia added a comment.

In D62584#1586640 <https://reviews.llvm.org/D62584#1586640>, @rjmccall wrote:

> In D62584#1585091 <https://reviews.llvm.org/D62584#1585091>, @Anastasia wrote:
> > In D62584#1583340 <https://reviews.llvm.org/D62584#1583340>, @rjmccall wrote:
> >
> > > Oh, yes, it definitely can't be done to class types.  I suppose we should just forget about it.
> >
> >
> > Ok, regarding address space qualifiers in template instantiation - is it still ok that we ignore them here in this patch?
> I think ignoring them in templates rather than diagnosing is the right thing to do, since it means that reasonable things, e.g. template functions returning `T`, won't be erroneous if you instantiate `T = __global int` just like they wouldn't be with `T = const int`.

Ok cool, I have removed the diagnostic btw. :)



More information about the cfe-commits mailing list