[PATCH] D64634: [clangd] Fix duplicate highlighting tokens appearing in initializer lists
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jul 15 07:52:21 PDT 2019
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM (I think @hokein 's comments were addressed too)
> So it seems to be expected. (and looking at the documentation for InitListExpr it seems to be difficult to change RecursiveASTVisitor to visit every sub expr once)
Ah, this particular piece of behavior seems really surprising to me.
We should definitely only traverse syntactic form if `shouldVisitImplicitCode() == true`, which should help us avoid this corner case here. But that's a topic for a separate patch, please land this to unbreak semantic highlighting.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits