[PATCH] D64624: [clangd] Added highlighting to enum constants.

[Johan Vikström via Phabricator via cfe-commits]

jvikstrom marked an inline comment as done.
jvikstrom added inline comments.


================
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:257
+  case HighlightingKind::EnumConstant:
+    return "constant.other.enum.cpp";
   case HighlightingKind::Namespace:
----------------
hokein wrote:
> hokein wrote:
> > could you check the tm scope on vscode? They seem to use `variable.other.enummember`.
> this comment is undone, vscode is using https://github.com/microsoft/vscode/blob/master/extensions/cpp/syntaxes/cpp.tmLanguage.json#L10024
Oh yeah, I was going to write a comment about keeping it as `constant.other.enum` or something similar to it. Because it's not really a variable. But as we've stuck to the same TM scopes as vscode we should probably keep doing that so I'll change to `variable.other.enummember` and land.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64624/new/

https://reviews.llvm.org/D64624