[PATCH] D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies

[Shoaib Meenai via Phabricator via cfe-commits]

smeenai added a comment.

In D64579#1581557 <https://reviews.llvm.org/D64579#1581557>, @beanz wrote:

> Yea, this makes sense even if it is a bit sad. We do use the `--whole-archive` approach for `libLLVM`, and it works. I was hoping to avoid it here in part to free up the ability to link `libclang_shared` before or in parallel to archiving the `libclang*.a` archives.


Yeah, makes sense. I've had issues with static libraries getting reordered out of the `--whole-archive` with other projects in the past, which makes me wary of it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64579/new/

https://reviews.llvm.org/D64579