[PATCH] D64489: [clangd][QueryDriver] Use language from underlying database if possible

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 11 05:44:50 PDT 2019


sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:121
   // Should we also preserve flags like "-sysroot", "-nostdinc" ?
-  const llvm::StringRef Args[] = {
-      Driver, "-E", "-x", driver::types::getTypeName(Type), "-", "-v"};
+  const llvm::StringRef Args[] = {Driver, "-E", "-x", Lang, "-", "-v"};
 
----------------
does gcc accept the same set of -x flags?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64489/new/

https://reviews.llvm.org/D64489





More information about the cfe-commits mailing list