[PATCH] D64506: clang-cl: Remove -O0 option

[Nico Weber via Phabricator via cfe-commits]

thakis added a comment.

In D64506#1579251 <https://reviews.llvm.org/D64506#1579251>, @rnk wrote:

> Does `clang-cl -O0` without a `/` still work, though? It's used:
>
> $ git grep O0 ../compiler-rt/test/asan/TestCases/Windows/
>  ../compiler-rt/test/asan/TestCases/Windows/aligned_mallocs.cc:// RUN: %clang_cl_asan -O0 %s -Fe%t
>  ../compiler-rt/test/asan/TestCases/Windows/allocators_sanity.cc:// RUN: %clang_cl_asan -O0 %s -Fe%t
>  ../compiler-rt/test/asan/TestCases/Windows/beginthreadex.cc:// RUN: %clang_cl_asan -O0 %s -Fe%t
>  ../compiler-rt/test/asan/TestCases/Windows/bitfield.cc:// RUN: %clang_cl_asan -O0 %s -Fe%t
>  ../compiler-rt/test/asan/TestCases/Windows/bitfield_uaf.cc:// RUN: %clang_cl_asan -O0 %s -Fe%t
>  ../compiler-rt/test/asan/TestCases/Windows/calloc_left_oob.cc:// RUN: %clang_cl_asan -O0 %s -Fe%t
>  ../compiler-rt/test/asan/TestCases/Windows/calloc_right_oob.cc:// RUN: %clang_cl_asan -O0 %s -Fe%t
>  ...


Oh thanks, I only ran clang tests, not compiler-rt tests.

It no longer works, O isn't a CoreOption:

  $ out/gn/bin/clang-cl test.cc -O0 /c
  clang: warning: argument unused during compilation: '-O0' [-Wunused-command-line-argument]

But these tests should just use `/Od`, right?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64506/new/

https://reviews.llvm.org/D64506