[PATCH] D62413: [OpenCL][PR41727] Prevent ICE on global dtors

[Anastasia Stulova via Phabricator via cfe-commits]

Anastasia marked an inline comment as done.
Anastasia added inline comments.


================
Comment at: lib/CodeGen/TargetInfo.h:274
+    return LangAS::Default;
+  }
+
----------------
rjmccall wrote:
> This target hook should just return the address space of the `__cxa_atexit` argument, not to claim anything specific about the relation between that address space and others.  That is a global and permanent property of the target ABI.  We should *advise* targets to use an address space that other major address spaces can be bitcast to, but ultimately that's just advisory.
> 
> This would be a good thing to include in a PR to the Itanium C++ ABI, but it would be reasonable to bundle all the address-space-related changes you need in one PR.
> This would be a good thing to include in a PR to the Itanium C++ ABI, but it would be reasonable to bundle all the address-space-related changes you need in one PR.

I can try to do it but I would need some explanation of the process. :)




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62413/new/

https://reviews.llvm.org/D62413