[PATCH] D63954: Add lifetime categories attributes

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 9 10:53:47 PDT 2019


xazax.hun added inline comments.


================
Comment at: clang/include/clang/Basic/AttrDocs.td:4177
+  let Content = [{
+When annotating a class ``P`` with ``[[gsl::Pointer(T)]]``, it assumed to be a
+non-owning type whose objects can point to ``T`` type objects or dangle.
----------------
aaron.ballman wrote:
> You don't reference `P` in the rest of the docs, is that intentional?
I think it is referenced implicitly after the comma by `it`. Would you prefer to get rid of the name `P` and only say `a class`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63954/new/

https://reviews.llvm.org/D63954





More information about the cfe-commits mailing list