[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

Neil Hickey via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 9 09:39:51 PDT 2019


neil.hickey added inline comments.


================
Comment at: docs/LanguageExtensions.rst:1538
+- ``dynamic_cast`` operator
+- Only placement ``new``/``delete`` operators
+- Standard C++ libraries. Currently there is no solution for alternative
----------------
This seems weird, you say the following features are not supported then say Only placement new/delete. I think you mean to say new/delete is not supported except for placement new and delete.


================
Comment at: docs/LanguageExtensions.rst:1549
+
+Address spaces are part of the type qualifiers. Therefore many rules are just
+inherited from the qualifier behavior documented in OpenCL C v2.0 s6.5 and
----------------
I'd replace ". Therefore" with "; "


================
Comment at: docs/LanguageExtensions.rst:1552
+Embedded C extension ISO/IEC JTC1 SC22 WG14 N1021 s3.1. Note that since the
+address space behavior in C++ is not documented formally yet Clang extends
+existing concept from C and OpenCL. For example conversion rules are extended
----------------
need a , between yet and Clang I think, to remove the ambiguity


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64418/new/

https://reviews.llvm.org/D64418





More information about the cfe-commits mailing list