[PATCH] D64276: [ItaniumMangle] Refactor long double/__float128 mangling and fix the mangled code

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 8 06:36:40 PDT 2019


erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.

I think the function names are awkward, but otherwise I think this should be acceptable.  I'll accept, but give 24 hrs for the other reviewers to get through their mondays.



================
Comment at: include/clang/Basic/TargetInfo.h:603
+  /// Return the mangled code of long double.
+  virtual const char *getMangledCodeOfLongDouble() const { return "e"; }
+
----------------
getLongDoubleMangling/getFloat128Mangling seems to make more sense for these names.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64276/new/

https://reviews.llvm.org/D64276





More information about the cfe-commits mailing list