[PATCH] D64289: [OpenMP] Fix 128-bit long double support on target

[Alexey Bataev via Phabricator via cfe-commits]

ABataev added inline comments.


================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8515
   "%0 is not supported on this target">;
+def err_type_not_equivalent : Error<
+  "%0 is not equivalent between host and target">;
----------------
No, this message shall tell something like `host requires %0 bit size %1 type support, but device %3 does not support it`. Here `%0` is the sizr of the host type in bits, `%1` is the type name and `%2` is the device triple.


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:1596
         << Ty << E->getSourceRange();
+  if (Ty->isRealFloatingType()) {
+    llvm::APFloatBase::Semantics Sem = llvm::APFloatBase::SemanticsToEnum(
----------------
Why do we need all this stuff? I think the original code works good here, we just need to improve the message.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64289/new/

https://reviews.llvm.org/D64289