[PATCH] D64127: [clangd] Deduplicate clang-tidy diagnostic messages.

[Sam McCall via Phabricator via cfe-commits]

sammccall added inline comments.


================
Comment at: clang-tools-extra/clangd/Diagnostics.cpp:427
   }
+  // Deduplicate clang-tidy diagnostics -- some clang-tidy checks may emit
+  // duplicated messages due to various reasons (e.g. the check doesn't handle
----------------
This sorting/partitioning seems a bit heavyweight... what about

```
DenseSet<pair<Range, Message>> SeenDiagnostics;
llvm::erase_if([&](const Diag &D) {
  return !SeenDiagnostics.try_emplace(D.Range, D.Message).second;
});
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64127/new/

https://reviews.llvm.org/D64127