[PATCH] D64199: [clangd] Added highlighting for variable references (declrefs)

[Haojian Wu via Phabricator via cfe-commits]

hokein added inline comments.


================
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:46
+
+  bool VisitDeclRefExpr(DeclRefExpr *Ref) {
+    if (Ref->getNameInfo().getName().getNameKind() ==
----------------
The `DeclRefExpr` is a very general expression, which can reference a variable, a function, an enum, etc. I think we want to distinguish with them (rather than putting all into `Variable` type).

 And we are missing large majority of entities now, I think we could start collecting more entities (class, method, enum, etc).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64199/new/

https://reviews.llvm.org/D64199