[PATCH] D56366: New warning call-to-virtual-from-ctor-dtor when calling a virtual function from a constructor or a destructor

Arnaud Bienner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 28 10:36:14 PDT 2019


ArnaudBienner added a subscriber: xbolva00.
ArnaudBienner added a comment.

Thanks @xbolva00  for adding reviewers and @rjmccall for reviewing!

@rjmccall as you might remember, we had a discussion on the mailing list ("Warning when calling virtual functions from constructor/desctructor?") and from what I understand the overall feeling was that this patch/warning won't be accepted until we move forward with your proposal of having a "-Wversion=" flag to allow deactivate new warnings when upgrading clang, but enable them by default otherwise.
Have you made any progress on that? Or do you think the warning can be implemented anyway? (maybe off by default?)

Just want to avoid spending our time reviewing/doing changes on a patch that won't be accepted in the end :)


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56366/new/

https://reviews.llvm.org/D56366





More information about the cfe-commits mailing list