[PATCH] D63786: Print NULL as "(null)" in diagnostic message

Hubert Tong via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 25 15:19:32 PDT 2019


hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
This revision is now accepted and ready to land.

LGTM. I have some minor style comments that could be fixed as part of the commit.



================
Comment at: clang/tools/c-index-test/c-index-test.c:4648
     unsigned line, column, offset;
-    const char *DiagOptionStr = 0, *DiagCatStr = 0;
-    
+    const char *DiagOptionStr = 0, *DiagCatStr = 0, *FileNameStr = 0;
     D = clang_getDiagnosticInSet(Diags, i);
----------------
Minor nit: The blank line that was removed helps readability (at least for me). Also, `FileNameStr` should be declared first to match the corresponding `CXString`s.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63786/new/

https://reviews.llvm.org/D63786





More information about the cfe-commits mailing list