[PATCH] D63760: [clangd] Address limitations in SelectionTree:

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 25 04:31:46 PDT 2019


sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: cfe-commits, arphaman, mgrang, jkorous, MaskRay, ilya-biryukov.
Herald added a project: clang.

- nodes can have special-cased hit ranges including "holes" (FunctionTypeLoc in void foo())
- token conflicts between siblings (int a,b;) are resolved in favor of left sibling
- parent/child overlap is handled statefully rather than explicitly by comparing parent/child ranges (this lets us share a mechanism with sibling conflicts)


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D63760

Files:
  clangd/Selection.cpp
  clangd/Selection.h
  clangd/unittests/SelectionTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63760.206413.patch
Type: text/x-patch
Size: 15404 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190625/19cf953e/attachment-0001.bin>


More information about the cfe-commits mailing list