[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 20 17:10:56 PDT 2019


NoQ added a comment.

In D62883#1552969 <https://reviews.llvm.org/D62883#1552969>, @xazax.hun wrote:

> In D62883#1552870 <https://reviews.llvm.org/D62883#1552870>, @Szelethus wrote:
>
> > - Uniqueing already tracked conditions as an (`Expr`, `ExplodedNode`) pair instead of on `Expr`
>
>
> I would be surprised to see the same ExploderNode multiple time a lot.  Also, ExploderNode will have a program point, so having both an ExploderNode and an Expr feels redundant to me.


(`Expr`, `LocationContext`) sounds right.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62883/new/

https://reviews.llvm.org/D62883





More information about the cfe-commits mailing list