[PATCH] D63533: [analyzer] Fix clang-tidy crash on GCCAsmStmt

[Dávid Bolvanský via Phabricator via cfe-commits]

xbolva00 added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Core/CoreEngine.cpp:401
+      case Stmt::GCCAsmStmtClass:
+        return;
     }
----------------
nickdesaulniers wrote:
> nickdesaulniers wrote:
> > NoQ wrote:
> > > Please add a TODO to actually implement this functionality.
> > And an `assert` that this `Stmt::isAsmGoto() == true`. (We should not hit this for any inline assembly, just asm goto statements)
> Take a look at other `assert`s in the codebase.  They usually are in the form: `assert(some_expr_should_be_true && "helpful error message when false");`
or llvm_unreachable :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63533/new/

https://reviews.llvm.org/D63533