[PATCH] D61809: [BPF] Preserve debuginfo array/union/struct type/access index

[Yonghong Song via Phabricator via cfe-commits]

yonghong-song marked an inline comment as done.
yonghong-song added a comment.

@eli.friedman Sorry for replying late. I am outside US and currently in PTO. Will back to US soon to address your comments.

> can we really expect the user to know which expressions to apply this to?

Yes, this is specifically targeting some bpf helper calls like bpf_probe_read. So users know which expressions to apply.

> I'd like to see an actual specification for this in docs/LanguageExtensions.rst at some point.

I will find a place to put this into docs/LanguageExtensions.rst.



================
Comment at: lib/CodeGen/CGExpr.cpp:663
+  while (true) {
+    const auto &Parents = getContext().getParents(*E);
+    if (Parents.size() != 1)
----------------
efriedma wrote:
> I'm not sure you can use getParents like this safely... it's not really meant for use inside of clang semantic analysis/code generation, and I don't think we recompute it as the AST changes.
Good point. Let me check whether I can traverse AST instead.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61809/new/

https://reviews.llvm.org/D61809