[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 19 09:40:05 PDT 2019


aaron.ballman added a comment.

In D63423#1550563 <https://reviews.llvm.org/D63423#1550563>, @xbolva00 wrote:

> We will be noisy in this case
>
>   #define IRQ_CHINT4_LEVEL        (11 ^ 7)
>   #define IRQ_CHINT3_LEVEL        (10 ^ 7)
>   #define IRQ_CHINT2_LEVEL        (9 ^ 7)
>   #define IRQ_CHINT1_LEVEL        (8 ^ 7)
>   


Sure, but do we not want to be noisy in a case like: `#define BAD_IDEA (2 ^ 16)`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63423/new/

https://reviews.llvm.org/D63423





More information about the cfe-commits mailing list