[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

Anton Afanasyev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 18 16:12:34 PDT 2019


anton-afanasyev added a comment.

In D63325#1549316 <https://reviews.llvm.org/D63325#1549316>, @lebedev.ri wrote:

> Hmm, i'm only now noticing how fraglie this looks.
>  How do we know that `clang::ParseAST` will only ever be called with `BackendConsumer` `ASTConsumer`?
>  How do we know that `BackendConsumer` will only ever be `ASTConsumer` from `clang::ParseAST`?


This could be true by design. But I agree it's fragile. We can admit several `Frontend` sections though. But with this admission first variant with two `Frontend` `TimeTraceScope`'s is more preferrable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63325/new/

https://reviews.llvm.org/D63325





More information about the cfe-commits mailing list