[PATCH] D62952: [analyzer][tests] Use normalize_sarif in place of diff_sarif

Tue Jun 18 09:22:07 PDT 2019

aaron.ballman added a comment.

In D62952#1548620 <https://reviews.llvm.org/D62952#1548620>, @hubert.reinterpretcast wrote:

> In D62952#1548593 <https://reviews.llvm.org/D62952#1548593>, @aaron.ballman wrote:
>
> > But is there a reason to not keep `%diff_sarif` and define it in terms of `%normalize_sarif | diff -U1 -b` within lit.local.cfg? I guess I don't see the benefit to exposing the call to diff (I don't anticipate anyone needing to change the options passed to diff).
>
>
> Yes: The normalization runs on stdin. `%diff_sarif` would then only make sense if stdin is one of the inputs, and I think the only input we can hardcode to be stdin is the one conventionally considered to be the reference input (which is not what we want).

Ah drat, I think you're right. Oh well! I think your approach makes sense to me then. Thank you for working on this!

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62952/new/

https://reviews.llvm.org/D62952