[PATCH] D62538: [clangd] Add hidden tweaks to dump AST/selection.

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

LGTM with a few NITs



================
Comment at: clangd/refactor/Tweak.h:104
+  /// Is this a 'hidden' tweak, which are off by default.
+  virtual bool hidden() const { return false; }
 };
----------------
I wonder whether this should be a static method. WDYT?

That would allow to even prevent calling `prepare()` on those tweaks.
OTOH, we want `prepare()` should be fast and it shouldn't matter if that's the case.


================
Comment at: clangd/unittests/TweakTests.cpp:19
 #include "llvm/Testing/Support/Error.h"
+#include "gmock/gmock-matchers.h"
 #include "gmock/gmock.h"
----------------
NIT: the include is redundant. Maybe remove? (probably added by clangd)


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62538/new/

https://reviews.llvm.org/D62538