[PATCH] D63454: [OpenMP] Strengthen regression tests for task allocation under nowait depend clauses NFC

[Jonas Hahnfeld via Phabricator via cfe-commits]

Hahnfeld added inline comments.


================
Comment at: test/OpenMP/target_constant_device_codegen.cpp:2-4
+// RUN: %clang_cc1 -verify -fopenmp -x c++ -triple powerpc64le-unknown-unknown -fopenmp-targets=powerpc64le-ibm-linux-gnu -emit-llvm %s -o - | FileCheck %s --check-prefix CHECK --check-prefix CHECK-64
+// RUN: %clang_cc1 -fopenmp -x c++ -std=c++11 -triple powerpc64le-unknown-unknown -fopenmp-targets=powerpc64le-ibm-linux-gnu -emit-pch -o %t %s
+// RUN: %clang_cc1 -fopenmp -x c++ -triple powerpc64le-unknown-unknown -fopenmp-targets=powerpc64le-ibm-linux-gnu -std=c++11 -include-pch %t -verify %s -emit-llvm -o - | FileCheck %s --check-prefix CHECK --check-prefix CHECK-64
----------------
I think you only need these 3 lines (although not really sure about the PCH).


================
Comment at: test/OpenMP/target_constant_device_codegen.cpp:13-33
+template<typename tx, typename ty>
+struct TT{
+  tx X;
+  ty Y;
+};
+
+int global;
----------------
Please only leave structs and variables that are really used and needed (in particular only one `depend`)


================
Comment at: test/OpenMP/target_constant_device_codegen.cpp:37
+
+  // CHECK: call i8* @__kmpc_omp_target_task_alloc({{.*}}, i64 -1)
+
----------------
Can you please also add another `target` region with a real clause + constant, ie `device(1)`?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63454/new/

https://reviews.llvm.org/D63454