[PATCH] D63371: Rewrite ConstStructBuilder with a mechanism that can cope with splitting and updating constants.

[John McCall via Phabricator via cfe-commits]

rjmccall added a comment.

Isn't `[[no_unique_address]]` only significant for empty members?  I'm not sure why they need significant support from constant-building, since they expand to no meaningful initializer.

We have some code we'll hopefully be upstreaming soon that relies on being able to do things with address-of-position placeholder values; I'm a little worried that the new structure here doesn't really support them.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63371/new/

https://reviews.llvm.org/D63371