[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/modernize/ReplaceMemcpyByStdCopy.h:41
+  std::unique_ptr<utils::IncludeInserter> Inserter;
+  const utils::IncludeSorter::IncludeStyle IncludeStyle;
+};
----------------
I think this could be determined from .clang-format.


================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:204
+  
+- New :doc:`modernize-replace-memcpy-by-stdcopy
+  <clang-tidy/checks/modernize-replace-memcpy-by-stdcopy>` check.
----------------
Please move into new checks list (in alphabetical order).


================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:207
+  
+  Replace all occurences of the C "memcpy" function by "std::copy".
 
----------------
Replace**s**. Please use double back-ticks to highlight language constructs.


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize-replace-memcpy-by-stdcopy.rst:6
+
+This check replaces all occurences of the C "memcpy" function by "std::copy"
+
----------------
Please make first sentance same as in Release Notes.


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize-replace-memcpy-by-stdcopy.rst:35
+
+   A string specifying which include-style is used, `llvm` or `google`. Default
+   is `llvm`.
----------------
I think this could be determined from project's .clang-format.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63324/new/

https://reviews.llvm.org/D63324