[PATCH] D61790: [C++20] add Basic consteval specifier

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 14 13:16:37 PDT 2019


rnk added inline comments.


================
Comment at: cfe/trunk/include/clang/Sema/DeclSpec.h:366
   // constexpr-specifier
-  unsigned Constexpr_specified : 1;
+  ConstexprSpecKind ConstexprSpecifier : 2;
 
----------------
Please always use `unsigned` for bitfields to avoid sign extensions under MSVC. I've fixed this in r363450. This makes the test you added pass on Windows (@dyung's comment).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61790/new/

https://reviews.llvm.org/D61790





More information about the cfe-commits mailing list