[PATCH] D63194: [clangd] Link in target infos and pass target and mode while invoking driver

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov marked an inline comment as done.
ilya-biryukov added inline comments.


================
Comment at: clang-tools-extra/clangd/test/target_info.test:8
+# (with the extra slash in the front), so we add it here.
+# RUN: sed -e "s|file://\([A-Z]\):/|file:///\1:/|g" %t.test.1 > %t.test
+
----------------
kadircet wrote:
> ilya-biryukov wrote:
> > This is added unconditionally on all platforms, right?
> > Why not just add this extra slash directly into the input file?
> no it is not, this checks whether we have a drive letter in the file uri ("[A-Z]:") and adds the slash in that case.
Ah, ok, LGTM. Missed that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63194/new/

https://reviews.llvm.org/D63194