[PATCH] D63164: [HIP] Add option to force lambda nameing following ODR in HIP/CUDA.

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 11 14:55:39 PDT 2019


tra added a comment.

So, in short, what you're saying is that lambda type may leak into the mangled name of a `__global__` function and ne need to ensure that the mangled name is identical for both host and device, hence the need for consistent naming of lambdas.

If that's the case, shouldn't it be enabled for CUDA/HIP by default? While it's not frequently used ATM, it is something we do want to work correctly all the time. The failure to do so results in weird runtime failures that would be hard to debug for end-users.

@rsmith -- are there any downsides having this enabled all the time?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63164/new/

https://reviews.llvm.org/D63164





More information about the cfe-commits mailing list