[PATCH] D63127: [clang-tidy] Fixed checker for abseil to work in C++17 mode

[Haojian Wu via Phabricator via cfe-commits]

hokein added a comment.

Thanks for investigating these, nice work!

Some initial comments:

- since your patch fixes four different check, I'd suggest to separate it (one patch per check)
- there are some non-functional changes (code format), I'd avoid them in this patch (we could address them in a separate patch)
- it would be nice if you could briefly describe the AST difference between C++11 and C++17 (how the fix work) in the patch description or comments



================
Comment at: clang-tools-extra/test/clang-tidy/abseil-duration-unnecessary-conversion.cpp:1
-// RUN: %check_clang_tidy -std=c++11,c++14 %s abseil-duration-unnecessary-conversion %t -- -- -I %S/Inputs
-// FIXME: Fix the checker to work in C++17 mode.
+// RUN: %check_clang_tidy -std=c++11,c++14,c++17 %s abseil-duration-unnecessary-conversion %t -- -- -I %S/Inputs
 
----------------
I believe the tests are also passed for C++2a? `use C++11-or-later` will do the trick.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63127/new/

https://reviews.llvm.org/D63127