[Diffusion] rL358949: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

Hubert Tong via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 5 08:39:29 PDT 2019


hubert.reinterpretcast added a comment.

> I think the name `ppc_wrappers` is accurate to describe its meaning that wrapping the headers under standard library path or standard header search path.

Thanks for clarifying this for me. In the case where all of the headers are expected to be present somewhere in the usual search path, I agree that the current directory structure would be okay given proper guards within the headers themselves.

> [ ... ] which I also prefer to use because it's easier to maintain headers instead of modifying cpp code about toolchain class such as PPCLinuxToolChain .



> We will use better way described above to guard those headers only in 64-bit mode soon after other headers have been upstreamed.

That (controlling within the headers) sounds good to me. When that lands, then my understanding is that the `PPCLinuxToolChain` code would be adjusted to include `ppc_wrappers` in the search path in the general case. Please let me know if that's not the case. Thanks.


https://reviews.llvm.org/rL358949





More information about the cfe-commits mailing list