[PATCH] D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 4 11:01:45 PDT 2019


lebedev.ri added a comment.

In D62850#1529588 <https://reviews.llvm.org/D62850#1529588>, @russell.gallop wrote:

> > We support non immediate on these because gcc does.
>
> Thanks. Your comment crossed in mid-air. Okay, so is this test worth changing, or should it have both versions (immediate and non-immediate)?


Both, i guess, with a comment as to why they are the way they are.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62850/new/

https://reviews.llvm.org/D62850





More information about the cfe-commits mailing list